Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov #2038

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Codecov #2038

merged 4 commits into from
Feb 22, 2021

Conversation

ahopkins
Copy link
Member

Make codecov a little more lenient. We can allow for the project percentage to vary, and then make codecov a hard passing PR requirement. If something is obviously missing tests, I would expect the PR reviewer to point that out.

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2038 (7c34b57) into master (baf9627) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2038   +/-   ##
=========================================
  Coverage   92.070%   92.070%           
=========================================
  Files           33        33           
  Lines         3102      3102           
  Branches       542       542           
=========================================
  Hits          2856      2856           
  Misses         166       166           
  Partials        80        80           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf9627...7c34b57. Read the comment docs.

@ahopkins ahopkins merged commit b461cc3 into master Feb 22, 2021
@ahopkins ahopkins deleted the codecov branch February 22, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant