Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.6 support #2036

Merged
merged 2 commits into from
Feb 21, 2021
Merged

Remove Python 3.6 support #2036

merged 2 commits into from
Feb 21, 2021

Conversation

ahopkins
Copy link
Member

Per conversation on forums v21.3 will drop Python 3.6 support. 20.12LTS will of course continue to support it.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #2036 (8f3e076) into master (8f8c00a) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
- Coverage   92.13%   92.06%   -0.07%     
==========================================
  Files          33       33              
  Lines        3104     3102       -2     
  Branches      542      542              
==========================================
- Hits         2860     2856       -4     
- Misses        165      166       +1     
- Partials       79       80       +1     
Impacted Files Coverage Δ
sanic/server.py 87.95% <100.00%> (-0.07%) ⬇️
sanic/__main__.py 75.00% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8c00a...8f3e076. Read the comment docs.

@ahopkins
Copy link
Member Author

This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there:

https://community.sanicframework.org/t/dropping-python-3-6/793/6

Copy link
Member

@ashleysommer ashleysommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@ashleysommer ashleysommer merged commit 6b86921 into master Feb 21, 2021
@ahopkins ahopkins deleted the drop-36 branch February 22, 2021 06:13
@ahopkins
Copy link
Member Author

Thanks. This will make it easier to clean up some of the other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants