Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw header info to request object #2032

Merged
merged 8 commits into from
Mar 3, 2021
Merged

Add raw header info to request object #2032

merged 8 commits into from
Mar 3, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Feb 17, 2021

Resolves #1963

This will add raw data from the header. Unit tests and final naming to come. I have been back and forth in my head about trying to keep it consistent with request.body. But, I also do not want to have to decode more than once. I might change my mind 4 more times before the PR is ready for review.

@ahopkins ahopkins marked this pull request as draft February 17, 2021 14:58
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #2032 (55e095f) into master (c41d713) will increase coverage by 0.030%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #2032       +/-   ##
=============================================
+ Coverage   91.811%   91.842%   +0.030%     
=============================================
  Files           35        35               
  Lines         3224      3236       +12     
  Branches       556       556               
=============================================
+ Hits          2960      2972       +12     
  Misses         179       179               
  Partials        85        85               
Impacted Files Coverage Δ
sanic/constants.py 100.000% <100.000%> (ø)
sanic/http.py 77.860% <100.000%> (+0.082%) ⬆️
sanic/mixins/routes.py 94.898% <100.000%> (ø)
sanic/request.py 97.924% <100.000%> (+0.067%) ⬆️
sanic/response.py 94.631% <100.000%> (+0.036%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41d713...55e095f. Read the comment docs.

@ahopkins ahopkins marked this pull request as ready for review February 24, 2021 19:08
@ahopkins
Copy link
Member Author

I pulled #2006 into this one. So, after that is merged this will be a much smaller PR.

@ahopkins ahopkins requested a review from a team March 1, 2021 14:56
@ahopkins ahopkins merged commit a733d32 into master Mar 3, 2021
@ahopkins ahopkins deleted the raw-request-header branch March 3, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In some cases, I need to get the raw request header
2 participants