Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router tweaks #2031

Merged
merged 7 commits into from
Mar 1, 2021
Merged

Router tweaks #2031

merged 7 commits into from
Mar 1, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Feb 17, 2021

@ahopkins ahopkins marked this pull request as draft February 17, 2021 13:56
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #2031 (ffe3450) into master (4b968dc) will increase coverage by 0.057%.
The diff coverage is 91.667%.

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #2031       +/-   ##
=============================================
+ Coverage   91.754%   91.811%   +0.057%     
=============================================
  Files           35        35               
  Lines         3226      3224        -2     
  Branches       557       556        -1     
=============================================
  Hits          2960      2960               
+ Misses         181       179        -2     
  Partials        85        85               
Impacted Files Coverage Δ
sanic/mixins/routes.py 94.898% <66.667%> (+0.959%) ⬆️
sanic/app.py 91.361% <88.889%> (-0.432%) ⬇️
sanic/request.py 97.857% <100.000%> (+0.015%) ⬆️
sanic/router.py 94.667% <100.000%> (+2.459%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b968dc...ffe3450. Read the comment docs.

@ahopkins ahopkins marked this pull request as ready for review February 28, 2021 18:18
Copy link
Contributor

@sjsadowski sjsadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real quibbles. Appreciate the increased internal consistency.

@ahopkins
Copy link
Member Author

ahopkins commented Mar 1, 2021

No real quibbles. Appreciate the increased internal consistency.

How about fake ones?

@ahopkins ahopkins merged commit 27f64dd into master Mar 1, 2021
@ahopkins ahopkins deleted the router-tweaks branch March 1, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants