Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config deprecations and resolve compat #1999

Closed
wants to merge 1 commit into from
Closed

Conversation

ahopkins
Copy link
Member

Removes the deprecated config methods from #1903, and resolves some compatibility with the old API.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #1999 (9a84a59) into master (7028eae) will decrease coverage by 0.56%.
The diff coverage is 29.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
- Coverage   92.02%   91.46%   -0.57%     
==========================================
  Files          30       29       -1     
  Lines        3323     3315       -8     
  Branches      579      580       +1     
==========================================
- Hits         3058     3032      -26     
- Misses        183      201      +18     
  Partials       82       82              
Impacted Files Coverage Δ
sanic/utils.py 25.53% <11.42%> (-9.09%) ⬇️
sanic/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7028eae...9a84a59. Read the comment docs.

@ahopkins
Copy link
Member Author

Lots more unit testing needed here.

@ahopkins ahopkins marked this pull request as draft January 11, 2021 13:25
@ahopkins
Copy link
Member Author

See #2007

@ahopkins ahopkins closed this Jan 19, 2021
@ahopkins ahopkins deleted the config-fix branch June 13, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant