21.3deprecations #1998

ahopkins · 2021-01-10T23:49:04Z

Removes some deprecations from #1903 and smooths over some compatibility with the old API.

…CRLF-CRLF.

…nger be supported. Chunked mode is now autodetected, so do not put content-length header if chunked mode is preferred.

…), all requests made streaming. A few compatibility issues and a lot of cleanup to be done remain, 16 tests failing.

…timeout=<value> which wasn't the case with existing implementation, and secondly none of the other web servers I tried include this header.

…led. Rewritten using receive_body and case switching to make it fail if bypassed.

…ions

codecov · 2021-01-10T23:49:09Z

Codecov Report

Merging #1998 (ef9a041) into master (7028eae) will decrease coverage by 1.28%.
The diff coverage is 29.54%.

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
- Coverage   92.02%   90.74%   -1.29%     
==========================================
  Files          30       29       -1     
  Lines        3323     3273      -50     
  Branches      579      580       +1     
==========================================
- Hits         3058     2970      -88     
- Misses        183      219      +36     
- Partials       82       84       +2

Impacted Files	Coverage Δ
sanic/utils.py	`25.53% <11.42%> (-9.09%)`	⬇️
sanic/config.py	`100.00% <100.00%> (ø)`
sanic/server.py	`84.67% <0.00%> (-3.35%)`	⬇️
sanic/response.py	`92.53% <0.00%> (-2.32%)`	⬇️
sanic/worker.py	`82.64% <0.00%> (-1.79%)`	⬇️
sanic/request.py	`98.30% <0.00%> (-0.90%)`	⬇️
sanic/http.py	`77.65% <0.00%> (-0.47%)`	⬇️
sanic/testing.py	`92.59% <0.00%> (-0.27%)`	⬇️
sanic/errorpages.py	`98.42% <0.00%> (-0.10%)`	⬇️
sanic/router.py	`96.07% <0.00%> (-0.06%)`	⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7028eae...ef9a041. Read the comment docs.

Tronic added 30 commits February 21, 2020 10:51

Streaming request by async for.

6279eac

Make all requests streaming and preload body for non-streaming handlers.

fe64a27

Cleanup of code and avoid mixing streaming responses.

f609a48

Async http protocol loop.

f6a0b4a

Change of test: don't require early bad request error but only after …

3d05e1e

…CRLF-CRLF.

Add back streaming requests.

ef4f233

Rewritten request body parser.

42d86bc

Misc. cleanup, down to 4 failing tests.

6b9f0ec

All tests OK.

b87364b

Entirely remove request body queue.

29c6f3c

Let black f*ckup the layout

6d8f598

Better testing error messages on protocol errors.

b2476bd

Remove StreamBuffer tests because the type is about to be removed.

d597137

Remove tests using the deprecated get_headers function that can no lo…

85c67a0

…nger be supported. Chunked mode is now autodetected, so do not put content-length header if chunked mode is preferred.

Major refactoring of HTTP protocol handling (new module http.py added…

85b1ad5

…), all requests made streaming. A few compatibility issues and a lot of cleanup to be done remain, 16 tests failing.

Terminate check_timeouts once connection_task finishes.

8a1baeb

Code cleanup, 14 tests failing.

57202bf

Much cleanup, 12 failing...

a553e64

Even more cleanup and error checking, 8 failing tests.

7f41c5f

Remove keep-alive header from responses. First of all, it should say …

85be576

…timeout=<value> which wasn't the case with existing implementation, and secondly none of the other web servers I tried include this header.

Everything but CustomServer OK.

2840e4c

Merge branch 'master' into streaming

f829893

Linter

5086076

Disable custom protocol test

fc16594

Remove unnecessary variables, optimise performance.

c0a0b50

A test was missing that body_init/body_push/body_finish are never cal…

5a96996

…led. Rewritten using receive_body and case switching to make it fail if bypassed.

Minor fixes.

1c42a5e

Remove unused code.

0712026

Py 3.8 check for deprecated loop argument.

d918655

Fix a middleware cancellation handling test with py38.

31a8706

Tronic and others added 26 commits June 21, 2020 16:29

Remove unnecessary use of format string.

4fd493e

Merge branch 'master' into streaming

dd87583

Bring back to current master

742bfa1

Merge in master

5c9a9c7

Cleanup tests

310442e

Remove artifact

e9056bb

Fix type checking

1c9ad0d

Mark test for skipping

335637f

Cleanup some edge cases

86722a6

Add ignore_body flag to safe methods

a4e3c77

Add unit tests for timeout logic

b9740bd

Add unit tests for timeout logic

4ec61ea

Fix Mock usage in timeout test

ad254c9

Change logging test to only logger in handler

8a39604

Windows py3.8 logging issue with current testing client

529d595

Add test_header_size_exceeded

9d70b0d

Merge in master

8f44347

Resolve merge conflicts

7dc6c77

Add request middleware to hard exception handling

468a0dd

Add request middleware to hard exception handling

01e6be7

Request middleware on exception handlers

668ffba

Merge branch 'master' of github.com:sanic-org/sanic into streaming

904d420

Linting

41a0a94

Cleanup deprecations

14753c7

Remove config deprecations and fix config compat

a2bff74

Merge branch 'master' of github.com:sanic-org/sanic into 21.3deprecat…

ef9a041

…ions

ahopkins closed this Jan 10, 2021

ahopkins deleted the 21.3deprecations branch January 10, 2021 23:56

ahopkins restored the 21.3deprecations branch January 18, 2021 20:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

21.3deprecations #1998

21.3deprecations #1998

ahopkins commented Jan 10, 2021

codecov bot commented Jan 10, 2021 •

edited

Loading

21.3deprecations #1998

21.3deprecations #1998

Conversation

ahopkins commented Jan 10, 2021

codecov bot commented Jan 10, 2021 • edited Loading

Codecov Report

codecov bot commented Jan 10, 2021 •

edited

Loading