Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reqs to get tox running #1986

Merged
merged 2 commits into from
Dec 24, 2020
Merged

Update reqs to get tox running #1986

merged 2 commits into from
Dec 24, 2020

Conversation

ahopkins
Copy link
Member

Looks like all of a sudden the requirements were killing builds. This was able to get things running again locally, but I think first priority after next release is a 100% overhaul of these and getting all versions up to date.

https://travis-ci.com/github/huge-success/sanic/jobs/464682171

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #1986 (ea9cf36) into master (6515dde) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
+ Coverage   92.49%   92.87%   +0.37%     
==========================================
  Files          29       29              
  Lines        3198     3241      +43     
  Branches      566      566              
==========================================
+ Hits         2958     3010      +52     
+ Misses        162      156       -6     
+ Partials       78       75       -3     
Impacted Files Coverage Δ
sanic/views.py 100.00% <0.00%> (ø)
sanic/blueprint_group.py 100.00% <0.00%> (ø)
sanic/response.py 98.71% <0.00%> (+0.01%) ⬆️
sanic/router.py 97.10% <0.00%> (+0.04%) ⬆️
sanic/request.py 99.23% <0.00%> (+0.04%) ⬆️
sanic/app.py 95.86% <0.00%> (+0.04%) ⬆️
sanic/errorpages.py 99.25% <0.00%> (+0.04%) ⬆️
sanic/worker.py 84.42% <0.00%> (+0.12%) ⬆️
sanic/testing.py 96.25% <0.00%> (+0.14%) ⬆️
sanic/server.py 82.17% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6515dde...ea9cf36. Read the comment docs.

@ahopkins ahopkins merged commit 112715e into master Dec 24, 2020
@ahopkins ahopkins deleted the tox-reqs branch December 24, 2020 23:34
@ahopkins ahopkins mentioned this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant