Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App registry #1979

Merged
merged 7 commits into from
Dec 28, 2020
Merged

App registry #1979

merged 7 commits into from
Dec 28, 2020

Conversation

ahopkins
Copy link
Member

See #1968

The purpose of this is to add a convenience for access an application instance.

from sanic import Sanic

app = Sanic.get_app("my_awesome_server")

@ahopkins ahopkins linked an issue Dec 10, 2020 that may be closed by this pull request
Sanic Server instance #1968
Closed
vltr
vltr reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@vltr vltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments ... They're just ideas - it's not my intention to start a big discussion over it.

sanic/app.py Show resolved Hide resolved
docs/sanic/getting_started.rst Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 25, 2020 •
edited
Loading

Codecov Report

Merging #1979 (54f3a2c) into master (262f89f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1979      +/-   ##
==========================================
+ Coverage   92.78%   92.81%   +0.03%     
==========================================
  Files          29       29              
  Lines        3241     3256      +15     
  Branches      566      569       +3     
==========================================
+ Hits         3007     3022      +15     
  Misses        158      158              
  Partials       76       76
Impacted Files Coverage Δ
sanic/app.py 96.00% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262f89f...54f3a2c. Read the comment docs.

vltr
vltr approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@vltr vltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@ahopkins ahopkins merged commit 449bc41 into master Dec 28, 2020
@ahopkins ahopkins deleted the app-registry branch December 28, 2020 20:47
@ahopkins ahopkins mentioned this pull request Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vltr vltr vltr approved these changes

@Tronic Tronic Awaiting requested review from Tronic

@harshanarayana harshanarayana Awaiting requested review from harshanarayana

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

@sjsadowski sjsadowski Awaiting requested review from sjsadowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanic Server instance
3 participants
@ahopkins @sjsadowski @vltr