Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load module test #1956

Merged
merged 4 commits into from
Oct 25, 2020
Merged

Fix load module test #1956

merged 4 commits into from
Oct 25, 2020

Conversation

ahopkins
Copy link
Member

There was a broken test in appveyor because of how the module's __name__ was being reported.

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #1956 into master will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
+ Coverage   91.90%   92.27%   +0.37%     
==========================================
  Files          29       29              
  Lines        3236     3236              
  Branches      570      570              
==========================================
+ Hits         2974     2986      +12     
+ Misses        185      171      -14     
- Partials       77       79       +2     
Impacted Files Coverage Δ
sanic/request.py 99.23% <0.00%> (+0.76%) ⬆️
sanic/server.py 81.61% <0.00%> (+0.93%) ⬆️
sanic/worker.py 84.42% <0.00%> (+1.63%) ⬆️
sanic/response.py 98.08% <0.00%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb3d368...5d7b073. Read the comment docs.

@ahopkins ahopkins requested a review from ashleysommer October 25, 2020 07:55
@ashleysommer ashleysommer merged commit 9e048bc into master Oct 25, 2020
@ahopkins ahopkins deleted the fix-load-module-test branch October 25, 2020 12:29
@ahopkins ahopkins mentioned this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants