Fix static routes registration on a blueprint #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows blueprint registration to add the bp's static routes to its list of own routes. So now blueprint middlewares will apply to a blueprint's static file routes. Fixes sanic-org#1953
|
AppVeyor is failing on |
digitalkaoz
reviewed
Oct 23, 2020
| uri, | ||
| methods=["GET", "HEAD"], | ||
| name=name, | ||
| host=host, | ||
| strict_slashes=strict_slashes, | ||
| )(_handler) | ||
| return _routes |
There was a problem hiding this comment.
i think this change is not necessary
ahopkins
approved these changes
Oct 24, 2020
|
@ashleysommer That test is broken. Looks like a problem with how it was written and is out of the scope for this PR. I am merging and ignoring that for now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability for app.static() to return the routes it created.
This allows blueprint registration to add the bp's static routes to its list of own routes.
So now blueprint middlewares will apply to a blueprint's static file routes.
Fixes #1953