Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving documentation. #1951

Merged
merged 3 commits into from
Oct 25, 2020

Conversation

tomaszdrozdz
Copy link
Contributor

@tomaszdrozdz tomaszdrozdz commented Oct 19, 2020

@ashleysommer @ahopkins
As promised and discussed in #1942 - tiny documentation improvements.
Deliberately not touching middlewares, listeners because there is another discussion pending around them.

Would it be good idea to keep this branch open so anyone anytime can improve documentation ?

@tomaszdrozdz
Copy link
Contributor Author

tomaszdrozdz commented Oct 19, 2020

And how about "introspection" section (#1949) ?
Should we have a new file for it in docs/sanic/introspection.rst ??

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #1951 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
+ Coverage   92.38%   92.47%   +0.09%     
==========================================
  Files          29       29              
  Lines        3242     3242              
  Branches      571      571              
==========================================
+ Hits         2995     2998       +3     
+ Misses        169      167       -2     
+ Partials       78       77       -1     
Impacted Files Coverage Δ
sanic/exceptions.py 100.00% <ø> (ø)
sanic/server.py 81.61% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca3e98...634b586. Read the comment docs.

@ahopkins ahopkins merged commit fd23b99 into sanic-org:master Oct 25, 2020
@ahopkins ahopkins mentioned this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants