Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --strict-markers for pytest #1924

Merged
merged 3 commits into from
Sep 27, 2020

Conversation

tomaszdrozdz
Copy link
Contributor

No description provided.

@tomaszdrozdz tomaszdrozdz mentioned this pull request Sep 8, 2020
@tomaszdrozdz
Copy link
Contributor Author

@ahopkins @myusko - please take a look.

@myusko
Copy link
Contributor

myusko commented Sep 25, 2020

@tomaszdrozdz Tests still failing, seems like we need to add markers = asyncio to tox.ini file.

cc @ahopkins

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #1924 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
+ Coverage   92.09%   92.19%   +0.09%     
==========================================
  Files          27       27              
  Lines        3100     3100              
  Branches      555      555              
==========================================
+ Hits         2855     2858       +3     
+ Misses        171      169       -2     
+ Partials       74       73       -1     
Impacted Files Coverage Δ
sanic/server.py 79.92% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e1513...de3b40c. Read the comment docs.

@ahopkins ahopkins merged commit 0b7eb49 into sanic-org:master Sep 27, 2020
@tomaszdrozdz tomaszdrozdz deleted the strict_markers_for_pytest branch September 29, 2020 10:24
@ahopkins ahopkins mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants