Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test response-middleware in the request_data context tests. #1888

Merged

Conversation

ashleysommer
Copy link
Member

@ashleysommer ashleysommer commented Jul 6, 2020

Add an additional step to the request_data context test. This checks if items stored a request.ctx are able to be accessed from a response-middleware after a response is issued.

This is to help debug and reproduce the error described by user verdebirth here: https://community.sanicframework.org/t/issue-with-request-ctx-in-response-middleware/611

…ecks if items stored a request.ctx are able to be accessed from a response-middleware after a response is issued.
@ashleysommer ashleysommer requested a review from ahopkins July 6, 2020 00:29
@ashleysommer
Copy link
Member Author

Unfortunately even after adding this extra test and running it through our test suite using Tox, I'm still not able to reproduce the error described by verdebirth here: https://community.sanicframework.org/t/issue-with-request-ctx-in-response-middleware/611

@ashleysommer
Copy link
Member Author

Note; linter is failing due to this issue: #1889

@ahopkins
Copy link
Member

ahopkins commented Jul 6, 2020

Placing on hold until #1889 is merged to fix isort

@ahopkins ahopkins removed the on hold label Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1888 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1888   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          27       27           
  Lines        3090     3090           
  Branches      553      553           
=======================================
  Hits         2845     2845           
  Misses        171      171           
  Partials       74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5ed10...941c655. Read the comment docs.

@ashleysommer
Copy link
Member Author

All tests passed now. Can be merged.

@ahopkins ahopkins merged commit 0072fd1 into sanic-org:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants