-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket subprotocol #1887
Websocket subprotocol #1887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Looks good. Just a couple small points.
Also, to fix the broken Travis build, you can run make black
to fix the linting issue.
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
==========================================
+ Coverage 92.06% 92.26% +0.19%
==========================================
Files 27 27
Lines 3089 3090 +1
Branches 552 553 +1
==========================================
+ Hits 2844 2851 +7
+ Misses 171 167 -4
+ Partials 74 72 -2
Continue to review full report at Codecov.
|
@ahopkins I fixed all the linter errors and made all the changes you requested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
In future, these tests can be combined into a single with @pytest-mark-parametrize
. But that can be a separate PR. Let's get this in.
Fix for issue #1878, @ahopkins for your review