-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanic as an entry point command #1866
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
+ Coverage 94.79% 94.81% +0.01%
==========================================
Files 24 24
Lines 2307 2314 +7
Branches 421 422 +1
==========================================
+ Hits 2187 2194 +7
Misses 75 75
Partials 45 45
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, probably better to expose entry_points via "entry_points/console_scripts" in setup.py
I might be wrong, but I believe that is what this PR provides. |
Exactly. |
ahh, sorry, didn't read that carefully.. just saw that
and thought differentlly. |
One thing that I have always thought missing was this:
Since we already have...
... this PR just goes one step further to adding the entrypoint to run the Sanic server with the
sanic
command.