Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for order of listeners #1805 #1834

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Update docs for order of listeners #1805 #1834

merged 1 commit into from
Apr 26, 2020

Conversation

pwalimbe
Copy link
Contributor

Added comments in the middleware listener section to highlight the order.
#1610

@Tronic
Copy link
Member

Tronic commented Apr 23, 2020

Now this got hit by the same problem as #1833 ffuuu... A bit of bad timing, but the CI will need fixing again.

@Tronic Tronic mentioned this pull request Apr 23, 2020
Closed
@pwalimbe
Copy link
Contributor Author

Adding 5 comment lines in .rst file. CI needs to handle this, right ??

@yunstanford yunstanford merged commit 9987893 into sanic-org:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunstanford yunstanford yunstanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwalimbe @Tronic @yunstanford