Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set content-type and content-length headers in exceptions. #1820

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Mar 28, 2020

Method not allowed responses were formatted in HTML but with content-length of 0, causing broken HTTP communication. ContentRangeErrors specified text/plain even though the response was actually HTML.

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #1820 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1820      +/-   ##
==========================================
- Coverage   92.05%   92.04%   -0.02%     
==========================================
  Files          23       23              
  Lines        2342     2339       -3     
  Branches      435      434       -1     
==========================================
- Hits         2156     2153       -3     
  Misses        143      143              
  Partials       43       43              
Impacted Files Coverage Δ
sanic/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120f026...dbe79ea. Read the comment docs.

@Tronic Tronic mentioned this pull request Mar 30, 2020
@yunstanford yunstanford merged commit 8abba59 into sanic-org:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants