Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid py38 test failure on Windows #1816

Closed
wants to merge 2 commits into from

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Mar 21, 2020

Reduces test data size to 3 MB instead of 30 MB. This should not affect what the tests are trying to accomplish but makes them run faster, which apparently was an issue on Windows until now. Each test includes a large number of requests each of which include this data, and I could get all of them passing if I commented out some of the others, without reducing data size.

Reducing data size makes the tests run much faster and now they pass on my Windows virtual machine with all requests enabled.

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #1816 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files          23       23           
  Lines        2309     2309           
  Branches      428      428           
=======================================
  Hits         2123     2123           
  Misses        143      143           
  Partials       43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b4efa...fda9556. Read the comment docs.

@Tronic
Copy link
Member Author

Tronic commented Mar 21, 2020

This is merged to #1808 and maintaining two branches is too troublesome. Closing this in favour of the other one.

@Tronic Tronic closed this Mar 21, 2020
@Tronic Tronic deleted the py38-windows-test branch March 21, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant