Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update getting_started.rst #1814

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Conversation

koug44
Copy link
Contributor

@koug44 koug44 commented Mar 20, 2020

Replacing command to install Sanic without uvloop as the provided one is not working (at least in my case)

I've took the working from your Pypi page

Replacing command to install Sanic without uvloop as the provided one is not working (at least in my case)
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #1814 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1814      +/-   ##
==========================================
+ Coverage   91.94%   92.18%   +0.23%     
==========================================
  Files          23       23              
  Lines        2309     2315       +6     
  Branches      428      425       -3     
==========================================
+ Hits         2123     2134      +11     
+ Misses        143      141       -2     
+ Partials       43       40       -3     
Impacted Files Coverage Δ
sanic/response.py 98.06% <0.00%> (-0.63%) ⬇️
sanic/views.py 100.00% <0.00%> (ø)
sanic/request.py 99.62% <0.00%> (+<0.01%) ⬆️
sanic/testing.py 97.97% <0.00%> (+0.02%) ⬆️
sanic/app.py 92.25% <0.00%> (+0.41%) ⬆️
sanic/router.py 97.07% <0.00%> (+1.51%) ⬆️
sanic/compat.py 86.20% <0.00%> (+16.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b4efa...f49600e. Read the comment docs.

Tronic
Tronic previously approved these changes Mar 26, 2020
yunstanford
yunstanford previously approved these changes Mar 28, 2020
@Tronic Tronic mentioned this pull request Mar 30, 2020
@yunstanford
Copy link
Member

hmm.. it's still waiting for travis-ci to report back results, looks like hanging there forever. Maybe it's easy to just bring up another pr

@Tronic
Copy link
Member

Tronic commented Apr 8, 2020

There were hangs like this with Travis on other PRs too, about two weeks ago. Making any new change on this will re-run it, probably with success. Most current PRs display various test failures although in reality they are all-OK, because of this and other test problems that should now be all fixed.

This PR in particular only affects docs in a way that could hardly cause any test failures.

@yunstanford
Copy link
Member

Yeah, but the merge button is disabled, and i can't merge it until travis-ci reports results back

@Tronic
Copy link
Member

Tronic commented Apr 9, 2020

@koug44 Could you push something (like merge master) to this PR so that tests can be run again and this can be merged? sigh

Dummy commit for Travis
@koug44 koug44 dismissed stale reviews from yunstanford and Tronic via f49600e April 9, 2020 12:21
@koug44
Copy link
Contributor Author

koug44 commented Apr 9, 2020

@koug44 Could you push something (like merge master) to this PR so that tests can be run again and this can be merged? sigh
Done

@yunstanford yunstanford merged commit d969fdc into sanic-org:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants