-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update getting_started.rst #1814
Conversation
Replacing command to install Sanic without uvloop as the provided one is not working (at least in my case)
Codecov Report
@@ Coverage Diff @@
## master #1814 +/- ##
==========================================
+ Coverage 91.94% 92.18% +0.23%
==========================================
Files 23 23
Lines 2309 2315 +6
Branches 428 425 -3
==========================================
+ Hits 2123 2134 +11
+ Misses 143 141 -2
+ Partials 43 40 -3
Continue to review full report at Codecov.
|
hmm.. it's still waiting for travis-ci to report back results, looks like hanging there forever. Maybe it's easy to just bring up another pr |
There were hangs like this with Travis on other PRs too, about two weeks ago. Making any new change on this will re-run it, probably with success. Most current PRs display various test failures although in reality they are all-OK, because of this and other test problems that should now be all fixed. This PR in particular only affects docs in a way that could hardly cause any test failures. |
Yeah, but the merge button is disabled, and i can't merge it until travis-ci reports results back |
@koug44 Could you push something (like merge master) to this PR so that tests can be run again and this can be merged? sigh |
Dummy commit for Travis
|
Replacing command to install Sanic without uvloop as the provided one is not working (at least in my case)
I've took the working from your Pypi page