Code

Fix Ctrl+C and tests on Windows.#1808

Code

Merged

yunstanford merged 29 commits intosanic-org:mastersanic-org/sanic:masterfrom Tronic:ctrlc-windowsTronic/sanic:ctrlc-windowsCopy head branch name to clipboardMar 26, 2020

+250-74

Commits

Commits on Mar 18, 2020

• Fix Ctrl+C on Windows.

  Tronic

  committed
  33388e6

• Disable testing of a function N/A on Windows.

  Tronic

  committed
  6ea8183

• Add test for coverage, avoid crash on missing _stopping.

  Tronic

  committed
  68fb963

Commits on Mar 20, 2020

• Initialise StreamingHTTPResponse.protocol = None

  Tronic

  committed
  da26adf

• Improved comments.

  Tronic

  committed
  1580ca6

• Merge branch 'typing-fix' into ctrlc-windows

  Tronic

  committed
  2356165

Commits on Mar 21, 2020

• Reduce amount of data in test_request_stream to avoid failures on Windows.

  Tronic

  committed
  6f536a1

• Merge branch 'py38-windows-test' into ctrlc-windows

  Tronic

  committed
  77a0e04

• The Windows test doesn't work on Windows :(

  Tronic

  committed
  ae03fce

• Use port numbers more likely to be free than 8000.

  Tronic

  committed
  fda9556

• Merge branch 'py38-windows-test' into ctrlc-windows

  Tronic

  committed
  1418003

• Disable the other signal tests on Windows as well.

  Tronic

  committed
  5f8fc0c

• Windows doesn't properly support SO_REUSEADDR, so that's disabled in Python, and thus rebinding fails. For successful testing, reuse port instead.

  Tronic

  committed
  036c1d7

• app.run argument handling: added server kwargs (alike create_server), added warning on extra kwargs, made auto_reload explicit argument. Another go at Windows tests

  Tronic

  committed
  dc5d682

Commits on Mar 22, 2020

• Revert "app.run argument handling: added server kwargs (alike create_server), added warning on extra kwargs, made auto_reload explicit argument. Another go at Windows tests"

  Show description for 46484eb
  Tronic

  committed
  46484eb

• Use random test server port on most tests. Should avoid port/addr reuse issues.

  Tronic

  committed
  6f55780

• Another test to random port instead of 8000.

  Tronic

  committed
  73a2416

• Fix deprecation warnings about missing name on Sanic() in tests.

  Tronic

  committed
  66ff770

• Linter and typing

  Tronic

  committed
  ed17a3c

• Increase test coverage

  Tronic

  committed
  41dff40

• Rewrite test for ctrlc_windows_workaround

  Tronic

  committed
  f58319f

• py36 compat

  Tronic

  committed
  fd2ba55

Commits on Mar 23, 2020

• py36 compat

  Tronic

  committed
  d3c8dd4

• py36 compat

  Tronic

  committed
  8514d1f

• Don't rely on loop internals but add a stopping flag to app.

  Tronic

  committed
  2b8a8dc

• App may be restarted.

  Tronic

  committed
  1257bd3

• py36 compat

  Tronic

  committed
  1c40860

• Linter

  Tronic

  committed
  b4f47e2

Commits on Mar 25, 2020

• Add a constant for OS checking.

  Tronic

  committed
  b3a38b7