Use f-strings instread str.format() #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myusko
requested review from
ahopkins,
abuckenheimer and
harshanarayana
and removed request for
abuckenheimer
|
LGTM, barring a few overlong lines (but black's line lengths are not enforced on tests). |
seemethere
approved these changes
Feb 25, 2020
|
Only issues are windows python 3.8 which probably needs to get yanked back out of appveyor since it makes it look like there's a problem and there is not. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Per a discussion on Sanic's community forum, it will be cool to use
f-stringsinstead ofstr.format().f-stringsare faster thanstr.format()That's the first phase and it only applies for
tests, if it looks good, next PR will be applied to core functionality.