Code cleanup in file responses #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
- Coverage 91.97% 91.95% -0.02%
==========================================
Files 23 23
Lines 2281 2276 -5
Branches 426 426
==========================================
- Hits 2098 2093 -5
Misses 142 142
Partials 41 41
Continue to review full report at Codecov.
|
|
Be damned fixed line lengths, black uglified the code again. |
Tronic
changed the title
|
This can be merged. I'll make another PR if there is further development. |
Tronic
changed the title
yunstanford
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids ugly hack of earlier commit and cleans up the other code as well.
Minor difference with streaming file response: headers are now sent without opening the file, so any errors will terminate the HTTP connection. Old behaviour was an uncaught exception causing a 500 response to be sent.
Ideally those errors would be handled and proper code (404, 403) be issued if opening the file fails.