Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #1755

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Update docs #1755

merged 2 commits into from
Jan 5, 2020

Conversation

Lagicrus
Copy link
Contributor

@Lagicrus Lagicrus commented Jan 4, 2020

Update the docs to handle the new empty() response as implemented by #1736

@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #1755 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1755   +/-   ##
======================================
  Coverage    92.3%   92.3%           
======================================
  Files          22      22           
  Lines        2274    2274           
  Branches      419     419           
======================================
  Hits         2099    2099           
  Misses        135     135           
  Partials       40      40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3430907...0fd08c6. Read the comment docs.

Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise LGTM

Empty
--------------

For responding with a empty message as defined by `RFC 2616 <https://tools.ietf.org/search/rfc2616#section-7.2.1>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a grammatical thing, not really a blocker

Suggested change
For responding with a empty message as defined by `RFC 2616 <https://tools.ietf.org/search/rfc2616#section-7.2.1>`_
For responding with an empty message as defined by `RFC 2616 <https://tools.ietf.org/search/rfc2616#section-7.2.1>`_

@seemethere seemethere merged commit 784d5cc into sanic-org:master Jan 5, 2020
@Lagicrus Lagicrus deleted the empty-response branch January 5, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants