Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade websockets, resolve incompatible issue between multidict and websockets #1635

Merged
merged 2 commits into from
Aug 12, 2019

Conversation

yunstanford
Copy link
Member

Fix: #1629
Resolve incompatible issue between multidict and websockets.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1635 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1635      +/-   ##
==========================================
+ Coverage   91.61%   91.63%   +0.01%     
==========================================
  Files          19       20       +1     
  Lines        2099     2103       +4     
  Branches      391      391              
==========================================
+ Hits         1923     1927       +4     
  Misses        138      138              
  Partials       38       38
Impacted Files Coverage Δ
sanic/asgi.py 92.52% <100%> (ø) ⬆️
sanic/compat.py 100% <100%> (ø)
sanic/response.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b4112...5dafa9a. Read the comment docs.

@ahopkins
Copy link
Member

Much needed. Thanks @yunstanford! Will look it over this weekend.

@yunstanford
Copy link
Member Author

I'd like to schedule a release for this patch, can you guys take a look ? @ahopkins @seemethere

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good like it should resolve the get_all issue.

@yunstanford yunstanford merged commit 3f9c94b into master Aug 12, 2019
@ahopkins ahopkins deleted the upgrade-websockets branch August 12, 2019 21:00
@snguyenthanh
Copy link

@yunstanford May I ask when this patch will get released ?

@ahopkins
Copy link
Member

This was not something introduced by 19.6. So, this will likely be a part of 19.9 released in September.

@blaisep
Copy link

blaisep commented Jan 4, 2020

Hi @Tronic , @ahopkins ,
When I tried to take over maintenance of the python-sanic in Fedora, I found that
Fedora packaging has blocked sanic because they require websockets >=8.0
( https://bugzilla.redhat.com/show_bug.cgi?id=1729908 )
Should I go ahead and hack the dependency file to see if I can force the build?
https://src.fedoraproject.org/rpms/python-sanic/pull-request/1
or I am asking for trouble.
I don't want to cast sanic in a bad light by shoehorning it into the Fedora disto.

@ahopkins
Copy link
Member

ahopkins commented Jan 6, 2020

Upgrading the dependency is on my short list of things to do for an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uvicorn and Sanic have incompatible websockets dependencies
4 participants