-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade websockets, resolve incompatible issue between multidict and websockets #1635
Conversation
…mp up websockets version to match uvicorn
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
+ Coverage 91.61% 91.63% +0.01%
==========================================
Files 19 20 +1
Lines 2099 2103 +4
Branches 391 391
==========================================
+ Hits 1923 1927 +4
Misses 138 138
Partials 38 38
Continue to review full report at Codecov.
|
Much needed. Thanks @yunstanford! Will look it over this weekend. |
I'd like to schedule a release for this patch, can you guys take a look ? @ahopkins @seemethere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good like it should resolve the get_all
issue.
@yunstanford May I ask when this patch will get released ? |
This was not something introduced by 19.6. So, this will likely be a part of 19.9 released in September. |
Hi @Tronic , @ahopkins , |
Upgrading the dependency is on my short list of things to do for an upcoming release. |
Fix: #1629
Resolve incompatible issue between multidict and websockets.