Fix #1587: add support for handling Expect Header #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
+ Coverage 91.3% 91.32% +0.01%
==========================================
Files 18 18
Lines 1828 1832 +4
Branches 351 352 +1
==========================================
+ Hits 1669 1673 +4
Misses 133 133
Partials 26 26
Continue to review full report at Codecov.
|
andreymal
reviewed
Jun 4, 2019
sanic/server.py
Outdated
| else: | ||
| self.write_error( | ||
| HeaderExpectationFailed( | ||
| "Unknow Expect: {expect}".format(expect=expect) |
ahopkins
previously requested changes
Jun 4, 2019
tests/test_request_stream.py
Outdated
|
|
||
| assert app.is_request_stream is True | ||
|
|
||
| request, response = app.test_client.post("/method_view", data=data, headers={"EXPECT": "100-continue"}) |
There was a problem hiding this comment.
Maybe parameterize the test with different capitalization and variation of the header?
|
Can we get a more descriptive PR title? |
yunstanford
changed the title
|
@seemethere added brief description. |
andreymal
reviewed
Jun 4, 2019
tests/test_request_stream.py
Outdated
| else: | ||
| with pytest.raises(ValueError) as e: | ||
| app.test_client.post("/method_view", data=data, headers={"EXPECT": "100-continue-extra"}) | ||
| assert "Unknow Expect: 100-continue-extra" in str(e) |
There was a problem hiding this comment.
Sorry for the flood but... Unknown? :)
seemethere
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1587
I've verified the fix with code-snippet posted in the issue page, and also added unit tests for verifying.