Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sanic.url_for method #1574

Closed
wants to merge 1 commit into from
Closed

Fix Sanic.url_for method #1574

wants to merge 1 commit into from

Conversation

myusko
Copy link
Contributor

@myusko myusko commented May 14, 2019

This is PR fixed #1420 issue.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #1574 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   91.35%   91.34%   -0.01%     
==========================================
  Files          18       18              
  Lines        1828     1826       -2     
  Branches      351      350       -1     
==========================================
- Hits         1670     1668       -2     
  Misses        132      132              
  Partials       26       26
Impacted Files Coverage Δ
sanic/app.py 92.45% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9255eb6...22404db. Read the comment docs.

@ahopkins
Copy link
Member

See #1591

@ahopkins
Copy link
Member

Is this still necessary?

@myusko myusko closed this Jul 5, 2019
@myusko myusko deleted the fix-url-for-flow branch July 5, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

url_for() doesn't return a working URI for a route with the trailing slash and strict_slashes=True
2 participants