Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graceful shutdown #1558

Merged
merged 2 commits into from
Apr 20, 2019
Merged

Fix graceful shutdown #1558

merged 2 commits into from
Apr 20, 2019

Conversation

andreymal
Copy link
Contributor

This line broke the graceful shutdown: https://github.com/huge-success/sanic/pull/1423/files#diff-bd84a6e523017a7f3d6bd72ee689dce2R110

Because a empty_set or set() expression will always create a new set insead of reusing an existing empty set

(The closed HttpProtocol is totally broken and unstable because self.transport is None >_<)

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #1558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1558   +/-   ##
======================================
  Coverage    91.4%   91.4%           
======================================
  Files          18      18           
  Lines        1804    1804           
  Branches      344     344           
======================================
  Hits         1649    1649           
  Misses        131     131           
  Partials       24      24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b68a7fe...99e56ef. Read the comment docs.

@seemethere seemethere requested a review from yunstanford April 19, 2019 22:51
@yunstanford yunstanford merged commit 6a4a3f6 into sanic-org:master Apr 20, 2019
@andreymal andreymal deleted the fix/graceful_shutdown branch April 20, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants