Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line broke the graceful shutdown: https://github.com/huge-success/sanic/pull/1423/files#diff-bd84a6e523017a7f3d6bd72ee689dce2R110
Because a
empty_set or set()
expression will always create a new set insead of reusing an existing empty set(The closed
HttpProtocol
is totally broken and unstable becauseself.transport
isNone
>_<)