Drop dependency on disutils #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While distutils is part of stdlib, it feels odd to use distutils in main application code. I personally use a (lean)[https://hub.docker.com/r/haizaar/python-minimal/tags] Python distribution for running my applications that does not include distutils.
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
- Coverage 91.45% 91.43% -0.03%
==========================================
Files 18 18
Lines 1791 1797 +6
Branches 339 341 +2
==========================================
+ Hits 1638 1643 +5
Misses 130 130
- Partials 23 24 +1
Continue to review full report at Codecov.
|
ahopkins
approved these changes
Apr 2, 2019
harshanarayana
approved these changes
Apr 2, 2019
haizaar
added a commit
to zarmory/docker-python-minimal
that referenced
this pull request
Jun 26, 2019
This reverts commit 03d05b1. New Sanic is out which has [1] merged. We can now safely drop distutils again. sanic-org/sanic#1544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day,
Recently sanic's main code started to use distutils solely for
disturils.util.strtoboolfunction.I use minimal python docker image (30MB) that does not include distutils. Distutils weighs 3MB which is 10% increase for the image size.
Hence I propose to implement
strtoboolfunction as part ofsanic/config.py.While distutils is part of stdlib and is expected to be present, it has a certain purpose and seeing
from distutilsimport in main application code may look odd to some.