Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "databases" #1489

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Added "databases" #1489

merged 1 commit into from
Feb 16, 2019

Conversation

tomchristie
Copy link
Contributor

Adds https://github.com/encode/databases to the "Database Integration" section.

Adds https://github.com/encode/databases to the "Database Integration" section.
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #1489 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   91.39%   91.45%   +0.05%     
==========================================
  Files          17       17              
  Lines        1731     1731              
  Branches      330      330              
==========================================
+ Hits         1582     1583       +1     
  Misses        123      123              
+ Partials       26       25       -1
Impacted Files Coverage Δ
sanic/router.py 95.89% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bf103...123f00e. Read the comment docs.

@vltr
Copy link
Member

vltr commented Feb 14, 2019

@tomchristie databases looks awesome! I could see it's in alpha yet, but out of curiosity: are you using it already to prototype some future service? I'll give it a shot tomorrow probably 😉

@tomchristie
Copy link
Contributor Author

I have something that I'll start using it with, yes.

Tho I'm pretty focused on building out more OSS tooling, rather than service-building right now. It's feasible that next up will be "and here's a fully-fledged ORM that sits on top of databases", but let's not get too far ahead of ourselves. 😝

@vltr
Copy link
Member

vltr commented Feb 14, 2019

@tomchristie hahaha yeah, that makes sense. SQLAlchemy is there now for more than 10 years and is rock solid enough to trust on it with eyes blindfolded. I think that if the necessity really grows, SQLAlchemy might end up with an async implementation by itself - we already have GINO and if my memory does not betrays me, @zzzeek once wrote in his blog (regarding the arrival of asyncio and etc) that the required changes in SQLAlchemy are actually "doable" to achieve that (section "SQLAlchemy? Asyncio? Yes?") - but he's the author, I think that thought must be deep buried in his mind ... But I'm eager to see more async stuff coming out of (or for) SQLAlchemy 😅

@yunstanford yunstanford merged commit ab56af5 into sanic-org:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants