Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanic-zipkin #1483

Merged
merged 1 commit into from
Feb 5, 2019
Merged

sanic-zipkin #1483

merged 1 commit into from
Feb 5, 2019

Conversation

kevinqqnj
Copy link
Contributor

add zipkin plugin.

Features:

  • adding "Request span" by default
  • if Request is from another micro-service endpoint, span will be attached (Inject/Extract) to that endpoint
  • use "logger" decorator to create span for "methods" calls
  • use "sz_rpc" method to create sub-span for RPC calls, attaching to parent span

@sjsadowski
Copy link
Contributor

I'm trying to identify what's going on with linting. We'll get this merged once that gets cleaned up.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #1483 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1483   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          17       17           
  Lines        1730     1730           
  Branches      328      328           
=======================================
  Hits         1582     1582           
  Misses        123      123           
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7d0f0...bd43a54. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #1483 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1483   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          17       17           
  Lines        1730     1730           
  Branches      328      328           
=======================================
  Hits         1582     1582           
  Misses        123      123           
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7d0f0...bd43a54. Read the comment docs.

@sjsadowski sjsadowski merged commit 4f70dba into sanic-org:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants