Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream support for bp.add_route() #1482

Merged

Conversation

chenjr0719
Copy link
Member

This PR adds stream argument for bp.add_route() to provide another solution if someone wants to using blueprint with request stream.

@chenjr0719
Copy link
Member Author

Just a record, Travis is failed at the lint check now. I think the reason is new releases of flake8(3.7.0 and 3.7.1). Try to fix it now.

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #1482 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
- Coverage   91.44%   91.38%   -0.06%     
==========================================
  Files          17       17              
  Lines        1730     1730              
  Branches      328      328              
==========================================
- Hits         1582     1581       -1     
  Misses        123      123              
- Partials       25       26       +1
Impacted Files Coverage Δ
sanic/response.py 100% <100%> (ø) ⬆️
sanic/router.py 95.43% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7d0f0...23bdc38. Read the comment docs.

Copy link
Contributor

@sjsadowski sjsadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sjsadowski sjsadowski merged commit 52bdd1d into sanic-org:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants