Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted None check for __repr__ in Request class #1472

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

xxNB
Copy link

@xxNB xxNB commented Jan 16, 2019

about #1451
i just delete and add "[]"😅

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #1472 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
- Coverage   91.45%   91.44%   -0.01%     
==========================================
  Files          17       17              
  Lines        1732     1730       -2     
  Branches      329      328       -1     
==========================================
- Hits         1584     1582       -2     
  Misses        123      123              
  Partials       25       25
Impacted Files Coverage Δ
sanic/request.py 99.51% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f34c9...af7ad0a. Read the comment docs.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xxNB Thanks so much for tackling this. Can you run a git rebase -i to squash your 4 commits down to 1?

@xxNB
Copy link
Author

xxNB commented Jan 16, 2019

@ahopkins Hi ahopkins. I am done.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🍻

@yunstanford yunstanford merged commit 2758a3a into sanic-org:master Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants