Config from object string #1436
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
+ Coverage 91.35% 91.41% +0.05%
==========================================
Files 18 18
Lines 1781 1793 +12
Branches 337 339 +2
==========================================
+ Hits 1627 1639 +12
Misses 130 130
Partials 24 24
Continue to review full report at Codecov.
|
|
Also, take a look at #1424 (as reference) to provide documentation to the |
| module_name is a valid path to class | ||
|
|
||
| """ | ||
| module, klass = module_name.rsplit(".", 1) |
There was a problem hiding this comment.
I might be overthinking this, but would it be a good idea to support relative string paths?
There was a problem hiding this comment.
well, i use this function in Flask for configure app using config_from_object and is very good.
Because is common in application has config classes.
example:
class Config:
DEBUG = False
class Develop(Config):
DEBUG = True
class Production(Config):
pass
In this case the user instanciate Sanic class and configure according from environment pass the string path of the class get from environment variable for example.
There was a problem hiding this comment.
In this case the user instanciate Sanic class and configure according from environment pass the string path of the class get from environment variable for example.
Oh I am totally with you on this feature. I was just curious if it might be possible to support relative path as well.
i.e. Instead of module1.module2.Class, if you are already inside module1, then module2.Class should suffice.
There was a problem hiding this comment.
@harshanarayana I think that the importlib searches the entire loaded packages, so I guess this already works out of the box - I might be wrong, testing still needed.
There was a problem hiding this comment.
@vltr It works, but the method invocation might need to be tweaked a bit to provide another helper argument. import_module(name, package=None)
There was a problem hiding this comment.
@harshanarayana oh, ok, got it. Some tweaking may be needed then ...
There was a problem hiding this comment.
@jotagesales looks like this is still outstanding - can you make changes so we can get this in soon?
There was a problem hiding this comment.
@sjsadowski ready ;)
tests/test_config.py
Outdated
| class Config: | ||
| not_for_config = "should not be used" | ||
| CONFIG_VALUE = "should be used" | ||
| class Config: |
There was a problem hiding this comment.
Can you please rename this class from Config to something else? This line is overriding the import done by from sanic.config import Config
This is causing tests to fail.
There was a problem hiding this comment.
@harshanarayana i renamed the class, thank.
There was a problem hiding this comment.
Renaming this class seems to be the only thing holding it up.
Implemented support in config_from_object method to receive a path by sting equal similar to Flask.