Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created methods to append and finish body content on Request #1310

Closed
wants to merge 1 commit into from
Closed

Conversation

vltr
Copy link
Member

@vltr vltr commented Sep 10, 2018

Hi! I just created two methods to append and finish the body content "feed" on request.py so the underlying body instance can have certain flexibility (example: one could use BytesIO instead of a list for storing the body data if a custom Request-like class is provided to the Sanic constructor).

I also modified server.py to reflect the changes on the Request class.

If any documentation is required regarding this, please let me know. Also, I'm not sure if this change is the best approach to the Request.body attribute so I'm open to suggestions 😉

…e underlying body instance can have certain flexibility; modified server.py to reflect these changes
@sjsadowski sjsadowski added this to the Future Release milestone Sep 27, 2018
@seemethere
Copy link
Member

@vltr would you mind rebasing your PR?

@vltr
Copy link
Member Author

vltr commented Oct 24, 2018

@seemethere yeah, no problem. In fact, one problem: unknown repository. How did I managed to do that? 😱

If I don't figure out if there's a way to fix this, I'll just make another PR replacing this one.

@vltr
Copy link
Member Author

vltr commented Oct 24, 2018

I was able to get the code from the PR, rebase and etc; but unknown repository PRs are readonly, so it is not possible to append directly 😒

So, I made a new PR #1379 to replace this one. Sorry for the mess.

@vltr vltr closed this Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants