Support flow control for request streaming #1220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0fls
reviewed
Jun 18, 2018
sanic/server.py
Outdated
| @@ -230,6 +233,18 @@ def data_received(self, data): | |||
| exception = InvalidUsage(message) | |||
| self.write_error(exception) | |||
|
|
|||
| if self.is_request_stream and not self._paused and \ | |||
There was a problem hiding this comment.
Can we turn self.request is not None and self.request.stream and self.is_request_stream and not self._paused and into a property? is_active_stream for instance.
r0fls
reviewed
Jul 11, 2018
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Request Streaming | |||
|
|
|||
| Sanic allows you to get request data by stream, as below. When the request ends, `request.stream.get()` returns `None`. Only post, put and patch decorator have stream argument. | |||
| Sanic allows you to get request data by stream, as below. When the request ends, `request.stream.get()` returns `None`. In order to do flow controll, calling `request.stream.task_done()` right after processing is required. Only post, put and patch decorator have stream argument. | |||
There was a problem hiding this comment.
nitpick, but can you fix the typo here, controll
|
@Jeffwhen final comment: can you demonstrate how to verify this works, or add a unit test? |
|
Closing as the PR author never responded to the reviewer's request and it's been 6+ months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#546
This may look naïve. But I tested it, and it worked. So I thought this might be helpful. Or at least bring this issue up so somebody else might git it fixed.