Any plans to support Ctrl+C on Windows?

[danieldaeschle]

No description provided.

[ahopkins]

I will be the first to admit that I am not aware of what would be involved to add this signal. 😬

Any one that is more versed in Windows want to chime in?

[ahopkins]

With a couple minutes of Google.... https://stackoverflow.com/a/52941752

[danieldaeschle]

Using windows api like in the example looks like a nice solution.

[ahopkins]

@danieldaeschle does CTRL-Break work?

[danieldaeschle]

I have to test it. Adam Hopkins <[email protected]> schrieb am Do., 9. Jan. 2020, 19:17:

…

@danieldaeschle <https://github.com/danieldaeschle> does CTRL-Break work? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1753>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHKTWHCKMIECAYCZP4YUKNDQ45S3JANCNFSM4KCOHVVQ> .

[seemethere]

I don't really feel like adding this functionality into sanic core would be greatly beneficial when there are already widely known alternatives.

Especially when the code solution to this is adding in a special case just for windows.

[Tronic]

I had planned to fix this but recently I don't have much time to work on Sanic at all. The problem might be that of terminating the worker processes, so it might already be resolved if you don't use workers or autoreload, and if that is the case, the thing needing implementation is better killing logic (because Windows doesn't have proper signals), e.g. closing child process stdin from parent.

[danieldaeschle]

@ahopkins I just tested Ctrl+Break. I doesn't work. Neither with 4 workers, nor with one worker.

In IDEs like PyCharm that isn't that bad. But in editors like vscode where you're using the terminal, you have to kill that terminal and create a new one every time.