Skip to content

Commit

Permalink
Merge pull request #1440 from harshanarayana/fix/Contribution_Guide_P…
Browse files Browse the repository at this point in the history
…ip_Install

fix minor type and pip install instruction mismatch
  • Loading branch information
yunstanford authored Dec 29, 2018
2 parents 13804dc + 15b1c87 commit 72f2e18
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ To install sanic without uvloop or ujson using bash, you can provide either or b
using any truthy string like `'y', 'yes', 't', 'true', 'on', '1'` and setting the ``SANIC_NO_X`` (``X`` = ``UVLOOP``/``UJSON``)
to true will stop that features installation.

- ``SANIC_NO_UVLOOP=true SANIC_NO_UJSON=true pip install sanic``
- ``SANIC_NO_UVLOOP=true SANIC_NO_UJSON=true pip3 install sanic``


Hello World Example
Expand Down
4 changes: 2 additions & 2 deletions docs/sanic/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ directory with a virtual environment already set up, then run:

.. code:: bash
pip3 install -e . '[.dev]'
pip3 install -e '.[dev]'
Dependency Changes
------------------
Expand All @@ -35,7 +35,7 @@ the document that explains the way ``sanic`` manages dependencies inside the ``s
| extras_require['test'] | for ``sanic`` | |
+------------------------+-----------------------------------------------+--------------------------------+
| extras_require['dev'] | Additional Development requirements to add | ``pip3 install -e '.[dev]'`` |
| | contributing | |
| | for contributing | |
+------------------------+-----------------------------------------------+--------------------------------+
| extras_require['docs'] | Dependencies required to enable building and | ``pip3 install -e '.[docs]'`` |
| | enhancing sanic documentation | |
Expand Down

0 comments on commit 72f2e18

Please sign in to comment.