This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in line 25, `endpoint` spelled error
Complete the translation of routing.md
Complete the translation of listener.md
Modify the subtitle level and change `Resonding early`/`Order of execution` from h2 to h4
@ahopkins In the process of translation, I found several places that need to be modified, and I made simple modifications. |
Yes, there is still lots of work to be done. The goal is to remove that BETA notice at the bottom simultaneously with the release of v21.3 which will include a PR to remove the docs from RTD. |
ahopkins
reviewed
Feb 22, 2021
@@ -104,7 +104,7 @@ async def halt_response(request, response): | |||
``` | |||
:--- | |||
|
|||
## Order of execution | |||
#### Order of execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this and not H2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at this file : basics/headers.md Tokens
and Proxy headers
are part of Headers
and they are H4 title.
In like manner, this also should be H4 title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignore
add package-lock.json