-
Notifications
You must be signed in to change notification settings - Fork 101
Changes to make docs ready for 21.3 launch #11
Conversation
☝️ Is this correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! NEW == 新的
I sometimes doubt Google Translate. Glad to know that it worked in this simple context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! NEW == 新的; Have tried locally, the config works fine in chinese parts.
There are a few places where we override the default. I would be curious to know if Chinese is also supported here. |
@ZinkLu and @miss85246 , I just added two documents that are more "organizational" than documentation. One covers various policies for Sanic, the other is the SCOPE (the document that describes how Sanic Community Org funcitons). I am not sure you want to go about translating those, especially the SCOPE. It is a long document, and really not too relevant for what you are doing. I imagine there will also be some changes to it before the end of the year, so I would hate for you to spend too much time treanslating that. |
It seems that a lot of files have been modified. I will take time to compare and modify the translation. Recently, I was busy. The company asked me to use golang to complete the HIDS program, and I felt a little hard. |
NP, I'll handle these new content. |
@ahopkins I think we should try to translate these "organizational" content, It seems very important to the community. |
Indeed. Golang is not very difficult, but it is very unaccustomed to it, it is less efficient, the leadership urged the tight, and it is done independently, so I feel a little embarrassed |
I don't disagree. Just meant that I think they are less important right now. Their utility is more for people wishing to be more deeply involved in the community and not just someone who wants to know how to use Sanic. There are a few new pages and some additions on a few pages with "new" stuff. The majority of the files have only changed their location. The PR is smaller than it would appear by looking at the file list. |
Sure, we'll foucus on main content, our target is make all content translated by the date 21.3 released.I shall try to translate community announcement if time permitting. I wonder whether all new content is on translation branch now? maybe another merge from lanuch should be done? |
I don't want to merge the launch branch until we release. Make commits directly on that branch with translations. It should have all the pages. |
NP |
I agree to translate "organizational" doc. Infact, I also hope a lot of people interested of sanic. For those who are interested, this document will be a good guide for participating. |
I think there are some changes from this commit missing: 588aef4 |
Busy week, will do tonight. |
Not criticizing, just a reminder. I think this is the last of the changes. Unless there is something SUPER important missing, I do not think I will have any more changes today. |
1. add vuepress block title 2. reformat doc
Add missing untranslated vuepress block titles in `proxy-headers.md`
👏👏👏 Job well done. If only I could read it 😆 |
🤔 I am pretty sure there are some contents has not been translated yet. A full review should be done. |
1. add block title for `advanced/streaming.md` ==> `en`|`zh` 2. fixed `basic/request.md` error return example ==> `en`|`zh` 3. modify running parameter display mode, from unordered list to table ==> `en`|`zh` 4. supplement the missing translation content for `basic/app.md` ==> `zh` 5. supplement the missing translation content for `basic/headers.md` ==> `zh` 6. reformat `basics/middleware.md` ==> `zh` 7. supplement the missing translation content for `basics/request.md` ==> `zh` 8. fixed `best-practices/blueprints.md` error translate content ==> `zh` 9. add new translation file `src/zh/guide/how-to/tls.md` ==> `zh`
1. add block title for `advanced/streaming.md` ==> `en`|`zh` 2. fixed `basic/request.md` error return example ==> `en`|`zh` 3. modify running parameter display mode, from unordered list to table ==> `en`|`zh` 4. supplement the missing translation content for `basic/app.md` ==> `zh` 5. supplement the missing translation content for `basic/headers.md` ==> `zh` 6. reformat `basics/middleware.md` ==> `zh` 7. supplement the missing translation content for `basics/request.md` ==> `zh` 8. fixed `best-practices/blueprints.md` error translate content ==> `zh` 9. add new translation file `src/zh/guide/how-to/tls.md` ==> `zh`
This time, I run the program and found out all untranslated content against en. See here for details |
@ZinkLu |
Ok, feel free to make a change and have another review if you are available. |
1. add toc title translation in config 2. unity translation of `context` and `connection` 3. reformat doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks all good to me.
This adds the documentation needed to get the docs ready for the 21.3 launch. I anticipate some more commits once the last few PRs are approved and merged into the core repository.
@ZinkLu and @miss85246, can you guys add commits to this PR with translations?
Also includes: