AST separation #777
Merged
AST separation #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
performantdata
force-pushed
the
ast-separation
branch
2 times, most recently
from
b9465d2 to
7724189
Compare
- Move `AstLocation`, `OperationType` and `QueryAst.scala` into a new `sangria-ast` module. - Move the object `ast.AstNode` to `schema.AstNodeTransformer`. - Move the `AstNode` rendering into new `QueryRenderer.renderPretty` and `QueryRenderer.renderCompact` methods. - Delete the `InputDocument.to` methods. The corresponding `InputDocumentMaterializer.to` method should be used instead.
performantdata
force-pushed
the
ast-separation
branch
from
7724189 to
0bc7074
Compare
Remove the `analyzer`, `separateOperations`, and the `separateOperation` methods from `Document`. These have no place in a concrete syntax tree representation. Move `SourceMapper.scala` into the `ast` package. `SourceMapper` includes methods that return localized strings (error messages), but those can be removed later. This is the easiest way not to disrupt the API too much. Fix the tests to work with the previous commit. Add type annotations, restrict member visibilities, documentation. Clean up IDE and build warnings.
yanns
reviewed
Nov 3, 2021
...les/benchmarks/src/main/scala/sangria/benchmarks/OverlappingFieldsCanBeMergedBenchmark.scala
Show resolved
Hide resolved
|
I'll try to use a snapshot later to check how important the breaking changes are. |
yanns
reviewed
Nov 3, 2021
yanns
reviewed
Nov 4, 2021
yanns
reviewed
Nov 4, 2021
Also fix warning.
|
performantdata#3 is cherry-picked. |
yanns
reviewed
Nov 5, 2021
yanns
reviewed
Nov 5, 2021
|
|
|
How/when does the CHANGELOG get updated? |
|
This should be added to the milestone. @yanns |
yanns
requested changes
Nov 10, 2021
manually, when we can. |
Co-authored-by: Yann Simon <[email protected]>
|
This change breaks some projects: #795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves separating the AST code into its own published module. Deprecation of what we throw away or change in the API should happen in a new 2.x branch, if desired.
This PR will help solve #461 and #466.