support for configuring max concurrent batches in fetcher #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanns
reviewed
Apr 14, 2021
|
|
||
| val groupedBatches: Iterator[TraversableOnce[Vector[Any]]] = ctx.fetcher.config.maxConcurrentBatchesConfig match { | ||
| case Some(size) ⇒ groupedIds.grouped(size) | ||
| case None ⇒ Iterator(groupedIds) |
There was a problem hiding this comment.
We are now using the =>. Can we change them?
There was a problem hiding this comment.
Replaced! I also updated .scalafmt.conf so no one has to ever think about it!
nickhudkins
force-pushed
the
config-fetcher-concurrency
branch
from
a1cb696 to
bffb820
Compare
added a new config param maxConcurrentBatches to configure the max number of batched IDs that can be fetched concurrently by fetcher. not specifying any value for this param will fallback to the existing behaviour of running all batches concurrently.
nickhudkins
force-pushed
the
config-fetcher-concurrency
branch
from
bffb820 to
4d96be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a new config param maxConcurrentBatches to configure
the max number of batched IDs that can be fetched concurrently by fetcher.
not specifying any value for this param will fallback to the existing
behaviour of running all batches concurrently.