validate that different instances of InputObjectType with the same name are the same #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me are the same The validation only check the field names. It cannot catch all cases, but I think it should be sufficient for 99% of the cases.
yanns
commented
Apr 9, 2021
| case Some(found) if !sameType(found._2, t) => | ||
| typeConflict(t.name, found._2, t, parentInfo) | ||
| if (t.isInstanceOf[ScalarAlias[_, _]] && found._2.isInstanceOf[ScalarType[_]]) |
There was a problem hiding this comment.
I've extracted the if to avoid calling sameType several times.
xsoufiane
approved these changes
Apr 9, 2021
Actually, we only test different field names as the class is not persisted with InputObjectType. I'll update the test name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation only checks the field names. It cannot catch all cases, but I think it should be sufficient for 99% of the cases.