Support Args in ProjectedNames #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Is it worth trying to make this binary compatible? It would add a pretty substantial amount of code just implementing |
yanns
approved these changes
Jan 22, 2021
nickhudkins
force-pushed
the
args-variables
branch
from
616a537
to
5462046
Compare
The following classes have binary incompatible changes. - sangria.schema.ProjectedName - sangria.schema.Args
nickhudkins
force-pushed
the
args-variables
branch
from
5462046
to
df41626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a little digging, thanks to @kirach's fork, I saw that the fix for the problem @yanns ran into sangria-graphql-org#10 (comment) was a trivial fix.
I also updated the test cases to ensure queries with variables are a tested case.
Closing #468 in favor of this due to nasty rebasing from a long out of date branch :)