Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check binary compatibility #552

Merged
merged 5 commits into from
Jan 1, 2021
Merged

check binary compatibility #552

merged 5 commits into from
Jan 1, 2021

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Dec 22, 2020

No description provided.

@yanns
Copy link
Contributor Author

yanns commented Dec 22, 2020

I guess I'll release a 2.0.2 version before activating this.

@nickhudkins
Copy link
Contributor

@yanns based on what we have queued up in master since the 2.0.1 release, (dropping scala 2.11 is included) I suspect we wanna go with a 2.1.0 release.

Happy to do this if you don't have time, unless you want to cherry-pick a 2.0.2 release that doesn't include the 2.11 support being dropped.

Let me know how I can help :)

@yanns
Copy link
Contributor Author

yanns commented Dec 31, 2020

I wanted to check what are the binary incompatible changes we've made, and if it's possible to fix that.
If not, we may go with a 2.1 release yes.

@yanns
Copy link
Contributor Author

yanns commented Dec 31, 2020

The binary changes is minimal:
From:

case class UnionType[Ctx](
    types: List[ObjectType[Ctx, _]],

to

case class UnionType[Ctx](
    typesFn: () => List[ObjectType[Ctx, _]],

364388c

I'll push a 2.1 release mentioning that.

@yanns
Copy link
Contributor Author

yanns commented Dec 31, 2020

@yanns
Copy link
Contributor Author

yanns commented Jan 1, 2021

@yanns yanns merged commit 96720fb into master Jan 1, 2021
@yanns yanns deleted the check_compatibility branch January 1, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants