Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafmt #548

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Scalafmt #548

merged 3 commits into from
Dec 17, 2020

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Dec 16, 2020

@nickhudkins what do you think of adding auto-formatting?

@zvuki
Copy link

zvuki commented Dec 16, 2020

Standardization/code formatting is great but I'm a bit worried that this can make merging/rebasing quite a mess if the folks who have improvements in their forks are willing to bring to main sangria (thinking Twitter and others...).

@yanns
Copy link
Contributor Author

yanns commented Dec 16, 2020

@zvuki Thx for the feedback. I don't think it's a real issue.

  • When looking into git history, it's easy to jump the "reformat" commit
  • other forks just have to copy the scalafmt config file and reformat all files before proposing a PR.

@nickhudkins
Copy link
Contributor

I love this, and have been avoiding doing it because I didn't want to end up with a massive diff like this but it makes contributing EASIER and removes any silly nitpicks. Yes PLEASE! @yanns

@yanns yanns merged commit 2fdb61c into master Dec 17, 2020
@yanns yanns deleted the scalafmt branch December 17, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants