Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy Union Types #534

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Lazy Union Types #534

merged 1 commit into from
Dec 9, 2020

Conversation

nickhudkins
Copy link
Contributor

@nickhudkins nickhudkins commented Dec 7, 2020 •
edited
Loading

Moves types for UnionType to be defined as a no-arg method à la fieldsFn on Field.

@nickhudkins nickhudkins marked this pull request as ready for review December 8, 2020 16:02
@nickhudkins nickhudkins requested a review from yanns December 8, 2020 16:02
@nickhudkins
Copy link
Contributor Author

Hey @srenault, I know it's been a LONG time coming, and it's entirely possible that you've moved on from Sangria, but if not... hoping to get this across the line. If you are still using it, I'd love to know if this helps you solve your use-case.

Thanks!

@nickhudkins nickhudkins changed the title Lazy Union Types? 🧐 Lazy Union Types Dec 8, 2020
yanns
yanns approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickhudkins nickhudkins merged commit 364388c into sangria-graphql:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanns yanns yanns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickhudkins @yanns