Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly resolve member types of type-parameterized classes #527

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Correctly resolve member types of type-parameterized classes #527

merged 1 commit into from
Oct 22, 2020

Conversation

nickhudkins
Copy link
Contributor

@nickhudkins nickhudkins commented Oct 22, 2020 •
edited
Loading

For macro-based schema derivation
Resolves #261

This is #457 but rebased :)

yanns
yanns approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yanns yanns merged commit 262c640 into sangria-graphql:master Oct 22, 2020
@nickhudkins nickhudkins mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanns yanns yanns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use type arguments in deriveObjectType
2 participants
@nickhudkins @yanns