Assorted refactorings

[nightscape]

I'm trying to understand the code a little better and applying small refactorings here and there.
I'm grouping them by theme, so that changes you don't like can be taken out.
Any comments welcome 😃

[OlegIlyenko]

Thanks a lot for working on the PR! In general I find it quite good 👍

I would suggest to avoid changes in TypeInfo and OverlappingFieldsCanBeMerged, but I think we can keep changes everywhere else. Both of these places are very often used so they might have big performance impact. Also OverlappingFieldsCanBeMerged needs to be kept in sync with reference implementation very closely (and it is the the most complex and expensive validation of them all).

WDYT?

[travisbrown]

@nightscape Would you be interested in migrating this PR to the new GitHub organisation?

[nickhudkins]

Hey @nightscape I've rebased and broken out the commits that Oleg had mentioned being worried about (with regards to performance).

My inclination is to drop the commits with [WARNING] in them unless we had some sort of benchmark to know if it has impact, even though my gut says that the changes don't scream performance issues.

I'm gonna go ahead and leave this PR open for now as is, and if I haven't heard back by early next week I'll go ahead and split the WARNING commits into their own PR.

[nightscape]

Hi @nickhudkins, thanks for taking care!
I wouldn't expect performance issues either (rather the other way around as the Scala collections might have optimized implementations), but your proposal about splitting into two PRs sounds like a good approach.

[nickhudkins]

@nightscape split :)

[yanns]

👍