Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include enums on directive args in schema introspection #1067

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

asteinwedel
Copy link

Currently we're only including unused types in the additional types of ast based schemas. This causes enums that are only used on directive args to be missed when generating an introspection query result, as we are not collecting types on directive args.

Currently we're only including unused types in the additional types of ast
based schemas. This causes enums that are only used on directive args to be
missed when generating an introspection query result, as we are not collecting
types on directive args.
@asteinwedel asteinwedel force-pushed the enum-introspection-bug branch from f8ec3d3 to 607fb59 Compare October 17, 2023 13:45
Copy link
Contributor

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yanns yanns added this pull request to the merge queue Oct 17, 2023
Merged via the queue into sangria-graphql:main with commit 7782dbc Oct 17, 2023
4 checks passed
@yanns
Copy link
Contributor

yanns commented Oct 17, 2023

Do you need a quick release for this change? Or do you have other changes on view before?

@asteinwedel
Copy link
Author

Do you need a quick release for this change? Or do you have other changes on view before?

would very appreciate a release with the other changes I made, thanks!

@yanns
Copy link
Contributor

yanns commented Oct 17, 2023

https://github.com/sangria-graphql/sangria/releases/tag/v4.1.0-RC2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants