Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/plot spacing #9

Merged
merged 7 commits into from
Jan 13, 2021
Merged

Conversation

SimonCW
Copy link

@SimonCW SimonCW commented Jan 7, 2021

Hi @sangonzal ,

thanks for the action! I added some horizontal spacing between the two subplots to show the full date.

I also noticed that the year is screwed up on the plot axes. My first suspicion was that the mixture of datetime.datetime and pd.TimeStamp in the updated_dict is causing this, however, I couldn't reproduce this locally. If you have other suspicions let me know and I'll try to fix it.

Best
Simon

@sangonzal
Copy link
Owner

@SimonCW Thanks! The date issue on the plot is weird, when I run it locally the date on the plots is correct. I don't know why it's not formatted correctly when it's run on a VM. If you don't get to it first, I'll try to take a look in the upcoming days.

Let me know if you want to merge this without the year fix, I'll do a release to the marketplace with your changes.

@SimonCW
Copy link
Author

SimonCW commented Jan 9, 2021

Hi @sangonzal, from my point of view we can wait with the release until we fix the time formatting issue.

Then, you experience the same weird behavior as I am: locally it is working fine. Unfortunately, I have no experience with developing Github actions, so I don't know of how much help I can be. I'll download https://github.com/nektos/act and try to get the traffic action running for my repo locally in their containers to see whether I can reproduce the behavior there.

@sangonzal
Copy link
Owner

sangonzal commented Jan 13, 2021

@SimonCW This seemed to be a bug with pandas - pandas-dev/pandas#34850

I've updated the version of pandas and that seemed fix the year formatting issue. Going to merge your PR and draft a release. You should be able to reference the latest changes by using version 0.1.4

@sangonzal sangonzal merged commit 2b24990 into sangonzal:dev Jan 13, 2021
@sangonzal
Copy link
Owner

@SimonCW v0.1.4 released! thanks for bringing this to my attention and fixing the spacing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants